Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify second template parameter #464

Merged
merged 1 commit into from Dec 15, 2022
Merged

Specify second template parameter #464

merged 1 commit into from Dec 15, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Dec 14, 2022 •
edited

The by-ref $value parameter is modified in DocLexer::getType(), but not its type, which stays a string. This guarantee that the token value will always be a string:

annotations/lib/Doctrine/Common/Annotations/DocLexer.php

Line 104 in 9e034d7

$value = str_replace('""', '"', substr($value, 1, strlen($value) - 2));

@greg0ire
Specify second template parameter
f46ab81 
The by-ref $value parameter is modified in DocLexer::getType(), but not
its type, which stays a string. This guarantee that the token value will
always be a string.
@greg0ire greg0ire added this to the 1.14.2 milestone Dec 14, 2022
@greg0ire greg0ire merged commit ad78521 into doctrine:1.14.x Dec 15, 2022
@greg0ire greg0ire deleted the fix-build branch December 15, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greg0ire @SenseException