Setup Psalm and reuse upstream workflows #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Oct 15, 2021
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0"?> | |||
| <psalm | |||
| errorLevel="7" | |||
There was a problem hiding this comment.
isn't it quite high as level (knowing that for psalm, higher levels are less strict) ?
There was a problem hiding this comment.
I assume, @greg0ire wants to start easy, so we can iterate further once the CI job is in place.
There was a problem hiding this comment.
I let Psalm pick the level itself with psalm --init. Level 6 finds 40 errors, which would make this PR a bit fat IMO.
There was a problem hiding this comment.
Yes exactly @derrabus . Also, this allows me to reuse all upstream workflows: the static analysis workflow cannot be reused if we don't have Psalm in the project.
derrabus
approved these changes
Oct 15, 2021
SenseException
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.