Use service name in the example #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By defining a new service for `Doctrine\Migrations\Version\DbalMigrationFactory` you overwrite the existing factory. The existing factory definition however is more complex when you have multiple connections defined. The connection is determined by the arguments passed to the console command. The original example breaks this behavior. By now the example is using the exiting service to decorate, allowing people with multiple connections to create a new decorator without breaking the behavior.
greg0ire
approved these changes
Apr 8, 2024
SenseException
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining a new service for
Doctrine\Migrations\Version\DbalMigrationFactoryyou overwrite the existing factory. The existing factory definition however is more complex when you have multiple connections defined. The connection is determined by the arguments passed to the console command. The original example breaks this behavior.By now the example is using the exiting service to decorate, allowing people with multiple connections to create a new decorator without breaking the behavior.