Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register event listener to remove migration table from comparison schema #529

Open
wants to merge 2 commits into
base: 3.3.x
Choose a base branch
from

Conversation

wmouwen
Copy link

@wmouwen wmouwen commented Mar 17, 2024

The PR doctrine/orm#11374 is created to add a new event to doctrine/orm: ToolEvents::postGenerateComparisonSchema. This event enables doctrine/migrations#1418 where the migration version table can be removed from the generated comparison schema.

This PR registers the new event listener with the Symfony container, fixing #1406.

> bin/console doctrine:schema:validate

Mapping
-------
                                                                                                             
 [OK] The mapping files are correct.                                                                         
                                                                                                             

Database
--------
                                                                                                             
 [OK] The database schema is in sync with the mapping files.                                                 
                                                                                                             

PR relates to an attempt to fix doctrine/migrations#1406. It requires doctrine/orm#11374 and doctrine/migrations#1418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doctrine:schema:validate returns DROP TABLE doctrine_migration_versions;
2 participants