Add support for --complete

[greg0ire]

When using orm:schema-tool:update together with --complete, all assets not described by the current metadata is dropped.

This is an issue when using doctrine/migrations, because not using that option is deprecated, and because when it is used, the table that holds the migrations is dropped as well since it is not described by ORM metadata.

A solution to that is configuring an asset filter that filters out the metadata table except when running commands inside the migrations namespace.

How can I test this?

composer config repositories.greg0ire vcs https://github.com/greg0ire/DoctrineMigrationsBundle
composer require doctrine/doctrine-migrations-bundle "dev-complete-compat as 3.3.0"

[greg0ire]

This is the part I am not sure about, because I have been enable to test it. I've tried accessing the schema filter manager definition in order to inspect it after the compiler pass, like this:

    public function testItRegistersTheSchemaFilterListener(): void
    {
        $container = $this->getContainer([]);

        $container->getDefinition('doctrine.dbal.schema_asset_filter_manager')->setPublic(true);
        $container->compile();

        $container->get('doctrine.dbal.schema_asset_filter_manager');
    }

That last line results in

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The "doctrine.dbal.schema_asset_filter_manager" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

Any ideas how to test this?

[wmouwen]

doctrine.dbal.schema_asset_filter_manager is defined as an abstract. The container builder removes unused and/or abstract definitions during its compilation causing the service to be hidden.

An example fix, not per se the wanted fix, could be:

$container
  ->getDefinition('doctrine.dbal.schema_asset_filter_manager')
  ->setAbstract(false)
  ->setArgument(0, [])
  ->setPublic(true);

[greg0ire]

Cc @FlyingDR :)