-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide deprecation warning #492
Conversation
@@ -14,7 +14,7 @@ | |||
*/ | |||
class DoctrineMigrationsBundle extends Bundle | |||
{ | |||
public function build(ContainerBuilder $container) | |||
public function build(ContainerBuilder $container): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class is not final, so this is technically a breaking change. You should use a phpdoc annotation instead:
public function build(ContainerBuilder $container): void | |
/** @return void */ | |
public function build(ContainerBuilder $container) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggest adding @final since 3.3.0
(or 3.4.0
depending on what is the next minor version) on that class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next minor version should be 3.3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @greg0ire said, we cannot add a return type to a non-final method in a minor release.
@adeptofvoltron up to do the suggested changes? |
#494 has been merged. |
Thanks. Let's close this one then. |
with symfony 6.1 I got such warning:
such change repair it