Merge 3.6.x up into 4.0.x #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update composer dump-autoload command syntax
Running the latest PHPStan produces this output: ``` ------ -------------------------------------------------------------------------------------------------------------- Line Loader/SymfonyFixturesLoader.php ------ -------------------------------------------------------------------------------------------------------------- 62 Call to an undefined static method Doctrine\Bundle\FixturesBundle\Loader\SymfonyBridgeLoader::addFixture(). 96 Call to an undefined static method Doctrine\Bundle\FixturesBundle\Loader\SymfonyBridgeLoader::getFixtures(). ------ -------------------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------------------------------------------------------------------ Line Tests/Command/LoadDataFixturesDoctrineCommandTest.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 27 Class Doctrine\Bundle\FixturesBundle\Loader\SymfonyFixturesLoader does not have a constructor and must be instantiated without any parameters. 50 Class Doctrine\Bundle\FixturesBundle\Loader\SymfonyFixturesLoader does not have a constructor and must be instantiated without any parameters. ------ ------------------------------------------------------------------------------------------------------------------------------------------------ ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line Tests/IntegrationTest.php ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 467 Return type mixed of method Doctrine\Bundle\FixturesBundle\Tests\ForwardCompatibleEntityManager::wrapInTransaction() is not covariant with return type mixed of method Doctrine\ORM\EntityManagerInterface::wrapInTransaction(). ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ``` All of them happen in the context of compatibility layers. The last one cannot be ignored for some reason.
Dismiss new PHPStan issues
Merge 3.5.x up into 3.6.x
Here are the steps I followed: - `mkdir src` - `git mv *.php src` - `git mv Command/ DependencyInjection Loader Purger src` - adjust autoloading path - overrode `Bunde::getPath()` - `git mv Resources/doc/ docs` - `git mv Resources/config/ config` - `git mv Tests/ tests`
The directory structure differs between both branches.
Switch to a modern directory structure
Configure docs path depending on the branch
Bump workflow actions
It is now no longer required to declare groups on all dependent fixtures, the fixture loader will now automatically find the required dependencies and load them without them being explicitly added to the groups being loaded. Before you were forced to declare groups all the way down the dependency chain, for example: ``` TopLevelFixture (groups: default) ├─ SecondLevelFixture1 (groups: default, alternative) │ ├─ ThirdLevelFixture1 (groups: default, alternative) ├─ SecondLevelFixture2 (groups: default) │ ├─ ThridLevelFixture2 (groups: default) │ ├─ ThirdLevelFixture3 (groups: default, alternative) ``` Now you only need to specify the groups at the highest level: ``` TopLevelFixture (groups: default) ├─ SecondLevelFixture1 (groups: alternative) │ ├─ ThirdLevelFixture1 (groups: none) ├─ SecondLevelFixture2 (groups: none) │ ├─ ThridLevelFixture2 (groups: none) │ ├─ ThirdLevelFixture3 (groups: alternative) ``` In both examples the groups `default` and `alternative` will load the same fixtures. Adds an additional PHPStan error to the baseline which appears to be caused by the backwards compatibility layer.
Automatically extract fixture dependencies
Merge 3.5.x up into 3.6.x
The right class to use now is in the DI component, which does make a lot more sense.
Address deprecation of HttpKernel Extension class
Update branch metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.