Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a return type in LoadDataFixturesDoctrineCommand #401

Closed
wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Contributor

Without this change, you see the following error when using this in a Symfony 7 app:

PHP Fatal error:  Declaration of

Doctrine\Bundle\FixturesBundle\Command\LoadDataFixturesDoctrineCommand::
execute(InputInterface $input, OutputInterface $output)

must be compatible with Symfony\Component\Console\Command\Command::
execute(InputInterface $input, OutputInterface $output): int

in vendor/doctrine/doctrine-fixtures-bundle/Command/LoadDataFixturesDoctrineCommand.php on line 99

@derrabus
Copy link
Member

Duplicate of #398? 🙃

@javiereguiluz
Copy link
Contributor Author

🤦 I'm sorry! I really want to test some app with Symfony 7 and this bundle is the one that prevents me to do that. That's why I'm so anxious. Sorry 🙏

@javiereguiluz javiereguiluz deleted the patch-5 branch October 26, 2023 18:48
@greg0ire
Copy link
Member

I don't know the Doctrine project code well enough, so I'm closing this PR and I will let you (or any other volunteer contributor) to do the proper fix based on the trait. Thanks a lot!

I think this does not have much to do with Doctrine, you were talking to a Symfony Core contributor, applying well known Symfony forward-compatibility hacks to a Symfony integration repository. Please give it a shot, and I will support you if you're stuck. That way you can test your app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants