Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing database "name" (=path) for SQLite #359

Open
wants to merge 1 commit into
base: 3.4.x
Choose a base branch
from
Open

Fixing database "name" (=path) for SQLite #359

wants to merge 1 commit into from

Commits on Nov 11, 2021

  1. Fixing database "name" (=path) for SQLite 

    Since DBAL 3.0 (see doctrine/migrations#1028), the message currently reads for SQLite:
> Careful, database "" will be purged. Do you want to continue? (yes/no)

Neither @Ocramius (see doctrine/dbal#3606 (comment)) nor me (see doctrine/dbal#4982) succeeded in convincing @morozov to continue returning the file path ;-) So it looks like the fix needs to be done here...

Suggestion: What about adding the platform too? So the message would be:
> Careful, MySQL database "foo" will be purged. Do you want to continue? (yes/no)

`doctrine/migrations` is currently broken too:

> WARNING! You are about to execute a migration in database "<unnamed>" that could result in schema changes and data loss. Are you sure you wish to continue? (yes/no) [yes]:

So when done here, I'm going to submit the same there  (i.e. follow up of doctrine/migrations#1028)
    @ThomasLandauer
    ThomasLandauer committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    42a800e View commit details
    Browse the repository at this point in the history