Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix rendering of code block #318

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

dritter
Copy link
Contributor

@dritter dritter commented May 11, 2020

Hi there!

The code block for writing a custom purger was rendered as comment block. This PR now renders it as proper code block.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the documentation, "Specifying purging behavior", seems to be only available in master. So I guess this is the correct target branch.

Copy link
Contributor

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to this repository to fix this issue ... so I'm glad this was already fixed by @dritter Thanks!

@greg0ire greg0ire merged commit a2f6b67 into doctrine:master May 19, 2020
@greg0ire
Copy link
Member

Thanks @dritter !

@dritter dritter deleted the patch-1 branch May 19, 2020 12:24
@greg0ire greg0ire added this to the 3.4.0 milestone Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants