avoid deprecation notice from LoadDataFixturesDoctrineCommand

[craue]

To get rid of the deprecation notice regarding Doctrine\Bundle\DoctrineBundle\Command\DoctrineCommand::getContainer(). This was missing in #280.

[yceruto]

Thanks @craue !

All these changes (included #280) to get rid of deprecations make this bundle now incompatible with DoctrineBundle 1.9 and prior versions. For example with DoctrineBundle 1.9 you'll get an error as doctrine instance is not the expected command name and getDoctrine() method does not exist.

[craue]

@yceruto, I wonder why this one wasn't triggered while running tests on Travis for #280.

[alcaeus]

@yceruto, I wonder why this one wasn't triggered while running tests on Travis for #280.

The tests are quite rudimentary, so there's a good chance the code is not being hit.

All these changes (included #280) to get rid of deprecations make this bundle now incompatible with DoctrineBundle 1.9 and prior versions. For example with DoctrineBundle 1.9 you'll get an error as doctrine instance is not the expected command name and getDoctrine() method does not exist.

#280 should be fine, as passing an extra argument to the constructor isn't a problem. However, this will make it incompatible with DoctrineBundle 1.9. I see two options here:

1. make the call to getDoctrine conditional: if the method exists, use the new logic, otherwise use the old.
2. Bump the minimum version of doctrine/doctrine-bundle to 1.10.x where the getDoctrine exists.

The first option allows us to fix this in a patch release, while the second option definitely requires a new minor release. I'd suggest using option and cleaning up the dependency in the next version.

[yceruto]

#280 should be fine, as passing an extra argument to the constructor isn't a problem.

In #280 the $doctrine instance is passed to the parent::__construct() method:

DoctrineFixturesBundle/Command/LoadDataFixturesDoctrineCommand.php

Line 41 in f5a3f11

parent::__construct($doctrine);

thus, it will be validated as command name, which will fail on preg_match().

[alcaeus]

Oh, yeah. I completely missed that. I’ll fix it later today in a patch release.

[alcaeus]

Superseded by #285. Thanks for bringing this up, @craue!