Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong query structure in tests #995

Merged
merged 1 commit into from Jul 14, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jul 14, 2019

With symfony/symfony#32163, the DoctrineDataCollector class ensures the types property of the query is an array. However, in our tests where we use a mock of the DebugStack, we did not add any type information whatsoever, leading to an error in our tests.

@alcaeus alcaeus added this to the 1.11.3 milestone Jul 14, 2019
@alcaeus alcaeus self-assigned this Jul 14, 2019
@alcaeus alcaeus merged commit 978b00b into doctrine:1.11.x Jul 14, 2019
@alcaeus alcaeus deleted the fix-wrong-query-in-mock branch July 14, 2019 20:06
@alcaeus alcaeus added this to 1.11 in Roadmap Aug 4, 2019
@alcaeus alcaeus modified the milestones: 1.11.3, 1.12.0 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant