ping/close connection middleware services #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested changes
Apr 23, 2019
insidestyles
force-pushed
the
WIP/doctrine-ping-connection-middleware
branch
from
71040f7
to
3ec6231
Compare
alcaeus
reviewed
Apr 24, 2019
sroze
approved these changes
Apr 28, 2019
alcaeus
changed the title
alcaeus
approved these changes
Apr 28, 2019
There was a problem hiding this comment.
Thanks @insidestyles! Waiting for symfony/symfony#31061 to be merged.
|
Merged :) |
|
Ok, let me figure out how to make sure the build is stable and then merge this. |
|
Build failure is unrelated and needs to be addressed separately. For now, I'm merging this. Thanks @insidestyles! |
alcaeus
changed the title
alcaeus
force-pushed
the
WIP/doctrine-ping-connection-middleware
branch
from
72ac70c
to
c0020d5
Compare
|
Thank you both @insidestyles & @alcaeus. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 29, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Note doctrine bundle version for middlewares Adds note regarding Doctrine middlewares being available since version 1.11 of the bundle See: doctrine/DoctrineBundle#956 Commits ------- afacf4c Note doctrine bundle version for middlewares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#31061