Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10] Don't fail build for the 3 known Twig deprecations #943

Merged
merged 1 commit into from Apr 2, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Apr 2, 2019

Twig deprecations were fixed in #929 but can't be fixed in 1.10 due to the change to twig requirements in composer.json. Thus, the build now allows three deprecations in general before failing the build.

@alcaeus alcaeus added this to the 1.10.3 milestone Apr 2, 2019
@alcaeus alcaeus self-assigned this Apr 2, 2019
@alcaeus alcaeus requested a review from ostrolucky April 2, 2019 12:20
@alcaeus alcaeus merged commit 845fd6b into doctrine:1.10.x Apr 2, 2019
@alcaeus alcaeus deleted the fix-110-build branch April 2, 2019 12:43
@alcaeus alcaeus added this to 1.10 in Roadmap Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants