Improvement in the listener description #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
requested changes
Mar 31, 2019
| event: preUpdate | ||
| entity: App\Entity\User | ||
| entity_manager: custom | ||
| - { name: doctrine.orm.entity_listener, entity: App\Entity\User, event: preUpdate } |
There was a problem hiding this comment.
The example shows the minimum attributes for a tag and what other attributes are available. Your changes drop this visualization. If your goal was to reduce confusion by removing one tag, you should create a new configuration block with the minimum and maximum amount of tag attributes.
You also need to adapt the XML part for the configuration to be equal to the YAML ones.
Can you please also add the lazy attribute to the configuration block with the maximum amount of tag attributes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description is confused. Improvement in the listener description.