fix Doctrine bridge version detection #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we cannot use feature changes to detect which version of the Doctrine bridge is installed I suggest that we parse the changelog and check if entries for 4.2 are present.
|
This certainly gets you points for creativity, but I wonder if it's more sensible to just install |
|
@alcaeus We still support PHP 5 in this branch, but ocramius/package-versions requires PHP 7. |
greg0ire
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Ok if we really have no other solution 👍
But I think we might, see #884 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we cannot use feature changes to detect which version of the
Doctrine bridge is installed I suggest that we parse the changelog and
check if entries for 4.2 are present.