New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #883 with support for php 5 #916

Closed

silverbackdan wants to merge 3 commits into doctrine:1.10.x from silverbackdan:1.10.x

silverbackdan commented Feb 3, 2019

This is an alternative approach to #884

I think all the methods being used here from ReflectionClass are supported from PHP 5 so hopefully tests will pass.

silverbackdan added 3 commits

February 3, 2019 14:11


          Fix doctrine#883 with support for php 5

ab01108


          CS fixes

756c14f


          Remove cs fixer cache file

ec7242b

Member

alcaeus commented Feb 4, 2019

Thanks for the attempt @silverbackdan, but this is not going to work. I'll close this PR as it has the same flaws as the original.

alcaeus closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment