Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][Entity Listeners] Mention lazy tag attribute #898

Merged
merged 1 commit into from Jan 10, 2019

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Dec 13, 2018

The lazy tag attribute was not mentioned in the docs.

This might be superfluous in case #899 can/will be done

@dmaicher dmaicher changed the title Mention lazy tag attribute for entity listeners [Documentation][Entity Listeners] Mention lazy tag attribute for entity listeners Dec 13, 2018
@dmaicher dmaicher changed the title [Documentation][Entity Listeners] Mention lazy tag attribute for entity listeners [Documentation][Entity Listeners] Mention lazy tag attribute Dec 13, 2018
Resources/doc/entity-listeners.rst Outdated Show resolved Hide resolved
@SenseException
Copy link
Member

There's currently only a master branch documentation of DoctrineBundle on the Doctrine website, but should we put this addition to earlier supported versions of the docs?

@dmaicher
Copy link
Contributor Author

Also related is this issue I created: #899

If we decide to implement that change then we might not even need to merge this PR.

@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2018

This might be superfluous in case #899 can/will be done.

Since 1.10 will be around a bit longer, it would still make sense to merge this.

@dmaicher
Copy link
Contributor Author

This could be merged? 😊

@greg0ire greg0ire requested a review from a team January 10, 2019 08:02
@alcaeus
Copy link
Member

alcaeus commented Jan 10, 2019

Ah, this should go into 1.10.x. Could you please change the base of the PR to 1.10.x and make sure no commits from master are in the PR? Thanks!

@greg0ire
Copy link
Member

so git rebase --onto 1.10.x master patch-1 (never tried it, but I saw that in the manual the other day)

@dmaicher dmaicher changed the base branch from master to 1.10.x January 10, 2019 08:49
@dmaicher
Copy link
Contributor Author

Done 😉

@alcaeus
Copy link
Member

alcaeus commented Jan 10, 2019

Okay. Build failure seems to be because travis-ci didn't choose the right branch when running the file. I've restarted the failing step to see if it will work this time.

@alcaeus alcaeus closed this Jan 10, 2019
@alcaeus alcaeus reopened this Jan 10, 2019
@alcaeus alcaeus self-assigned this Jan 10, 2019
@alcaeus alcaeus merged commit 891b58b into doctrine:1.10.x Jan 10, 2019
@alcaeus
Copy link
Member

alcaeus commented Jan 10, 2019

Thanks @dmaicher!

@dmaicher dmaicher deleted the patch-1 branch January 10, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants