Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop oldstable dependency version support: bump *all* dependencies to current stable release #873

Closed
wants to merge 2 commits into from
Closed

Drop oldstable dependency version support: bump *all* dependencies to current stable release #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb7178
Drop oldstable dependency version support: bump *all* dependencies to…
Ocramius Nov 4, 2018
874a471
Simplified CI pipeline to only run against current supported PHP and …
Ocramius Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 3 additions & 28 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -7,11 +7,8 @@ cache:
- $HOME/.composer/cache

php:
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3
- nightly

env:
Expand All @@ -31,37 +28,15 @@ script:

jobs:
include:
- php: 5.5
env: deps=low SYMFONY_DEPRECATIONS_HELPER=weak
install:
- travis_retry composer update -n --prefer-lowest --prefer-stable --prefer-dist

- php: 5.6
env: SYMFONY_VERSION="2.8.*"

- php: 7.0
env: SYMFONY_VERSION="3.2.*"

- php: 7.1
env: stability=RC SYMFONY_DEPRECATIONS_HELPER=weak SYMFONY_VERSION="3.4.*"
install:
- travis_retry composer update -n --prefer-dist

- php: 7.1
- php: 7.2
env: stability=dev SYMFONY_DEPRECATIONS_HELPER=weak SYMFONY_VERSION="4.1.*"
install:
- composer require --dev "symfony/messenger" --no-update
- travis_retry composer update -n --prefer-dist

- php: 7.2
env: stability=alpha
install:
- composer config minimum-stability alpha
- travis_retry composer update -n --prefer-dist

- stage: Code Quality
env: CODING_STANDARDS
php: 7.1
php: 7.2
install:
- travis_retry composer require -n --prefer-dist --dev doctrine/coding-standard:^5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now move this to composer.json directly. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but would need the usual composer.lock ballet too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it to separate PR, we can enable some 7.1+ sniffs that were excluded and also use use function. 😉 cc @carusogabriel if you're interested

script:
Expand Down
37 changes: 17 additions & 20 deletions composer.json
View file
Open in desktop
Expand Up @@ -24,28 +24,25 @@
}
],
"require": {
"php": "^5.5.9|^7.0",
"symfony/framework-bundle": "^2.7.22|~3.0|~4.0",
"symfony/console": "~2.7|~3.0|~4.0",
"symfony/dependency-injection": "~2.7|~3.0|~4.0",
"doctrine/dbal": "^2.5.12",
"jdorn/sql-formatter": "^1.2.16",
"symfony/doctrine-bridge": "~2.7|~3.0|~4.0",
"doctrine/doctrine-cache-bundle": "~1.2"
"php": "^7.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SF 4 requires PHP 7.1, this bundle should IMO do the same, at least until 5.0 GA.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this needs to stay 7.1 for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to follow symfony's dependency versioning: the bundle can define its own dependency versions (and it should)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bundle for the Symfony eco-system and it is built for Symfony and should follow the Symfony release cycle they follow and document publicly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we discussed, discussed and discussed again ad-nauseam.

If the package still has to live under doctrine/*, then keep it under our maintenance with our constraints and our ability to maintain it.

If it is part of the Symfony LTS cycle yaddayaddawhatever, then let's push it under symfony/* and call it a day.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the 7.1 users won't be able to upgrade Symfony.

This is not a problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony eco-system still supports 7.1 and this bundle is built for that eco-system.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: not a problem. You get the new features when you get to upgrade.

As mentioned above, this is a bundle, and if it should be maintained outside the doctrine organisation then I don't understand why it is in here in first place. If the release goes hand in hand with symfony, make it part of the symfony subtree split..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that is just where it ended up several years ago. Where it is in github is irrelevant imo. Github has features to handle this, we have outside collaborators who have the ability to maintain this bundle (and they do). You can control notifications per repository, etc.

I can't think of any reason why it can't be moved but I also don't think it is a very big deal for the repository to live here and follow the documented release lifecycle of Symfony.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't think it is a very big deal for the repository to live here and follow the documented release lifecycle of Symfony.

It is a big deal for my inbox, from what I can see.

Alright then, closing as won't fix here, will simply mute the repo.

"symfony/framework-bundle": "^4.1.7",
"symfony/console": "^4.1.7",
"symfony/dependency-injection": "^4.1.7",
"doctrine/dbal": "^2.8.0",
"jdorn/sql-formatter": "^1.2.17",
"symfony/doctrine-bridge": "^4.1.7",
"doctrine/doctrine-cache-bundle": "^1.3.3"
},
"require-dev": {
"doctrine/orm": "~2.4",
"symfony/yaml": "~2.7|~3.0|~4.0",
"symfony/validator": "~2.7|~3.0|~4.0",
"symfony/property-info": "~2.8|~3.0|~4.0",
"symfony/phpunit-bridge": "~2.7|~3.0|~4.0",
"twig/twig": "~1.26|~2.0",
"php-coveralls/php-coveralls": "^2.1",
"phpunit/phpunit": "^4.8.36|^5.7|^6.4",
"symfony/web-profiler-bundle": "~2.7|~3.0|~4.0"
},
"conflict": {
"symfony/http-foundation": "<2.6"
"doctrine/orm": "^2.6.2",
"symfony/yaml": "^4.1.7",
"symfony/validator": "^4.1.7",
"symfony/property-info": "^4.1.7",
"symfony/phpunit-bridge": "^4.1.7",
"twig/twig": "^2.5.0",
"php-coveralls/php-coveralls": "^2.1.0",
"phpunit/phpunit": "^6.5.9",
"symfony/web-profiler-bundle": "^4.1.7"
},
"suggest": {
"symfony/web-profiler-bundle": "To use the data collector.",
Expand Down