Add a deprecation notice for this feature #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stof Should I put the env var SYMFONY_DEPRECATIONS_HELPER=weak on every build ? |
stof
requested changes
Apr 13, 2017
It can be replaced by comment feature of the doctrine Type object.
mikeSimonson
force-pushed
the
deprecate-type-comment-config
branch
from
f2f4cf5
to
e978431
Compare
|
@mikeSimonson No. you should add |
stof
requested changes
Jul 10, 2017
| @@ -84,6 +84,9 @@ private function initializeTypes() | |||
| Type::addType($type, $typeConfig['class']); | |||
| } | |||
| if ($typeConfig['commented']) { | |||
| @trigger_error( | |||
| sprintf('The commented option of the type configuration is deprecated since DoctrineBundle 1.7.' . | |||
| 'Use the feature of the Type class instead. (in %s)', $type), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
I would say Use the "requiresSQLCommentHint" method of the Type class instead
|
Superseded by #947. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be replaced by comment feature of the doctrine
Type object.