Add a new use_trigger_error_for_deprecations config setting

[mpdude]

This adds a new use_trigger_error_for_deprecations config setting that can be used to make doctrine/deprecations report deprecations through trigger_error.

That way, those deprecations should show up in the same place/way as other Symfony deprecations.

See #1662 for the preceding discussion.

TODO

• Document the new setting
• Add UPGRADING notice?

[greg0ire]

Will this default change in 3.0.0? If yes, should we deprecate not configuring this node explicitly?
As a follow-up, I think a contribution should be made to the Symfony recipe, setting it to true.

[mpdude]

I don’t see why it should change?

[greg0ire]

If we merge like this, we close the door on having the possibility to rather use a PSR logger, or even something custom that will use getTriggeredDeprecations.

Another possibility would be to have something more complex:

deprecations:
    strategy: trigger_error|psr_logger|just_track # defaults to trigger_error
    strategy_options:
        logger: my_psr_logger # only valid when the strategy is psr_logger

[mpdude]

That's true.

My point is that, from a Symfony user's perspective, I do not care all too much about all the options the doctrine/deprecations package offers. I understand that it needs to provide this flexibility since it is a library underlying Symfony and other frameworks.

However, in Symfony, there is a way to capture, see and log deprecation messages – and I do not see why DoctrineBundle users would want to use any other (additional) way.

So, this flag is available to say "I want to see and notice Doctrine deprecations just like I see Symfony deprecations".

If you need any other way of specialized Doctrine deprecation handling, you can still configure it yourself.

[ostrolucky]

See discussion at symfony/symfony#41408 for reasons why this wasn't and won't be done in a bundle.

[mpdude]

I find that discussion difficult to understand. If I get it right, the conclusion is that since doctrine/deprecations would be enabled (or should be possible to enable it) for all Doctrine project libraries, not only ORM or ODM, the only place suitable for such code would be a DoctrineDeprecationsBundle.

Speaking for Doctrine ORM users, those that actively go out and search for ORM deprecations will end up adding a single line to their bootstrapping code. Those who only know about (and rely on) the “Symfony way” of reporting deprecations will be surprised when they try the next major upgrade.

[mpdude]

#1300 was discussed two years ago but did not implement anything in the end.

[ostrolucky]

From what I understood it doesn't need to be a new package but bundle code could be part of doctrine/deprecations. So effort to improve this situation should go there. And yeah I guess reason why it wasn't implemented was that nobody cares enough to implement it, like usual. Btw this should be non-confiruable true IMHO, nothing else makes sense in symfony framework world.