Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to integrate middleware #1653

Merged
merged 12 commits into from May 10, 2023

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 3, 2023

Introduced in #1472

@l-vo l-vo mentioned this pull request May 3, 2023
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
l-vo and others added 9 commits May 7, 2023 22:13
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
@l-vo
Copy link
Contributor Author

l-vo commented May 7, 2023

@greg0ire thank you for your careful review. Updated 🙂

@greg0ire greg0ire requested a review from a team May 7, 2023 21:50
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
Resources/doc/middlewares.rst Outdated Show resolved Hide resolved
l-vo and others added 2 commits May 8, 2023 14:09
Co-authored-by: Alexander M. Turek <me@derrabus.de>
Co-authored-by: Alexander M. Turek <me@derrabus.de>
@l-vo
Copy link
Contributor Author

l-vo commented May 8, 2023

@fabpot @derrabus suggestions applied, thank you 🙂

@l-vo l-vo changed the title Add documentation to integrate middlewares Add documentation to integrate middleware May 8, 2023
@greg0ire
Copy link
Member

greg0ire commented May 9, 2023

Given where the DBAL discussion is going, I'd use git reflog to revert to a version where Middleware is countable.

@l-vo
Copy link
Contributor Author

l-vo commented May 9, 2023

According to the choice in doctrine/dbal#6033, I followed @greg0ire advice and reverted "Middleware is uncountable"

@ostrolucky ostrolucky changed the base branch from 2.8.x to 2.9.x May 10, 2023 07:19
@ostrolucky ostrolucky merged commit 82d4362 into doctrine:2.9.x May 10, 2023
22 checks passed
@ostrolucky ostrolucky added this to the 2.9.2 milestone May 10, 2023
@l-vo l-vo deleted the add_middlewares_doc branch May 12, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants