[DoctrineBundle] remove doctrine.event_subscriber tag and replace by doctrine.event_listener tag #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alli83
force-pushed
the
doctrine-bundle-switch-subscribers-tag-to-listeners-tag
branch
2 times, most recently
from
77b10b9
to
b5c5053
Compare
nicolas-grekas
approved these changes
Apr 21, 2023
|
What about those defined in xml config files? 🤔 https://github.com/search?q=repo%3Adoctrine%2FDoctrineBundle%20doctrine.event_subscriber&type=code |
|
All doctrine schema subscribers are deprecated since 6.3 and are going to be removed and replaced by their respective doctrine schema listeners already present in xml config files if I'm not wrong. |
dmaicher
approved these changes
Apr 25, 2023
ostrolucky
approved these changes
Apr 25, 2023
|
Not sure if we should do this in patch release |
True. This should target 2.10.x. |
|
ok thanks ! i rebase and update the targeted branch then |
…doctrine.event_listener tag
alli83
force-pushed
the
doctrine-bundle-switch-subscribers-tag-to-listeners-tag
branch
from
b5c5053
to
89ac05c
Compare
|
Thanks @alli83 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 5, 2023
…ed (alli83) This PR was merged into the 6.3 branch. Discussion ---------- [DoctrineBridge] skip subscriber if listener already defined | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | | Tickets | | License | MIT | Doc PR | Following #49918 and doctrine/DoctrineBundle#1650 skip doctrine event subscriber if a doctrine event listener is already defined for the same definition. Commits ------- 5a867c5 [DoctrineBridge] skip subscriber if listener already defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove doctrine.event_subscribers tag in bundle and replace them with doctrine.event_listener tag.
following symfony/symfony#49918