-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove messenger transport service conditionally #1602
Conversation
Not sure about the best way to test based on optional dependencies, so I manually composer required/removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the best way to test based on optional dependencies, so I manually composer required/removed symfony/messenger and symfony/doctrine-messenger to verify the new tests locally. Should they be added to require-dev like doctrine/orm for some of the other tests in DoctrineExtensionTest?
The way we do it is that we manually require symfony/messenger in CI already (for some jobs)
- name: "Require symfony/messenger" |
Maybe it would make sense to add the new combinations ( |
I don't think adding another combination to matrix has enough ROI, so no need to do something around that. |
Thx, merged manually |
Fixes #1601