Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some DBAL 3.5 deprecations in commands #1566

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dmaicher
Copy link
Contributor

Fixes #1565

@dmaicher dmaicher marked this pull request as ready for review October 27, 2022 07:24
@dmaicher dmaicher requested a review from ostrolucky October 27, 2022 07:24
@ostrolucky ostrolucky added this to the 2.8.0 milestone Oct 27, 2022
@dmaicher dmaicher merged commit 71c68ca into doctrine:2.8.x Oct 27, 2022
@dmaicher dmaicher deleted the fix_dbal_deprecations branch October 27, 2022 10:55
$tmpConnection->getSchemaManager()->createDatabase($name);
$schemaManager = method_exists($tmpConnection, 'createSchemaManager')
? $tmpConnection->createSchemaManager()
: $tmpConnection->getSchemaManager();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another usage of getSchemaManager in the computation of $shouldNotCreateDatabase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn missed that. Will create a follow-up PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants