Deprecate "collate" default table option #1478
Merged
+43
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
reviewed
Feb 13, 2022
ConnectionFactory.php
Outdated
| @@ -86,6 +87,11 @@ public function createConnection(array $params, ?Configuration $config = null, ? | |||
| after dropping support for doctrine/dbal 2, since this | |||
| package requires doctrine/dbal 3.3.2 or higher. */ | |||
| if (isset($params['defaultTableOptions']['collate']) && defined('Doctrine\DBAL\Connection::PARAM_ASCII_STR_ARRAY')) { | |||
| Deprecation::trigger( | |||
| 'doctrine/doctrine-bundle', | |||
| 'https://github.com/doctrine/DoctrineBundle/pull/1478', | |||
There was a problem hiding this comment.
Wouldn't it be better if this was link to DBAL where they changed from collate to collation?
There was a problem hiding this comment.
I think you are right, since here defaultTableOptions is only validated as an array, and there is no validation of the keys. Let me change that.
"collation" is what is expected now on the DBAL side.
greg0ire
force-pushed
the
deprecate-collate
branch
from
f77e271 to
04e73d1
Compare
ostrolucky
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"collation" is what is expected now on the DBAL side.