Make PHP 8 build green #1220
Merged
Make PHP 8 build green #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertContains() is no longer supposed to be used with strings.
greg0ire
force-pushed
the
allow-phpunit-93
branch
from
9090cdf
to
392eda0
Compare
greg0ire
force-pushed
the
allow-phpunit-93
branch
from
392eda0
to
16e0643
Compare
It is a code smell, but I am not sure it makes sense to introduce a public interface for this.
That version is compatible with PHP 8
greg0ire
force-pushed
the
allow-phpunit-93
branch
2 times, most recently
from
7958030
to
0b4bd67
Compare
greg0ire
force-pushed
the
allow-phpunit-93
branch
from
0b4bd67
to
4114425
Compare
| @@ -140,7 +138,7 @@ public function testReset() : void | |||
| $noProxyManager->expects($this->once()) | |||
| ->method('clear'); | |||
|
|
|||
| $proxyManager = $this->getMockBuilder([LazyLoadingInterface::class, EntityManagerInterface::class])->getMock(); | |||
| $proxyManager = $this->createMock(LazyLoadingEntityManagerInterface::class); | |||
There was a problem hiding this comment.
Why did you create LazyLoadingEntityManagerInterface? Isn't the previous multi-interface mock creation not working anymore in PHP 8?
There was a problem hiding this comment.
It does not have to do with PHP 8, but with PHPUnit 9, which no longer supports it because it's a code smell IIRC.
There was a problem hiding this comment.
There was a problem hiding this comment.
Guess I have to remove another one of my old code snippets 😄
SenseException
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.