[WAIT] Ping command #1035
[WAIT] Ping command #1035
Conversation
|
it looks like you submitted your PR to a different branch than the one you used to start your work. |
|
@mcfedr you've created the branch from the master branch, when it should've been 1.12.x. Please rebase your branch and remove all commits from the master branch that aren't in 1.12 (i.e., all but your last commit). If you need help, let me know. |
yep, i think i accidently created an extra PR, wasn't clear which branch I should use, but its resolved now. |
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) | ||
| { | ||
| DoctrineCommandHelper::setApplicationConnection($this->getApplication(), $input->getOption('connection')); |
There was a problem hiding this comment.
I think it would be possible to use a configurator to achieve the addOption call, but I can't think of a way to have the functional equivalent of this line without resorting to a console listener and exposing the input… so I guess extension is the only way here, unless someone has an idea…
|
FYI, I'll wait until the corresponding DBAL PR is merged before merging this one. |
mcfedr
force-pushed
the
ping-command
branch
2 times, most recently
from
8acc4d3
to
16009b8
Compare
|
At this point this is more than one year old. Please reopen after you address issues in upstream PR. |
This just reflects the command from upstream in the same way the other commands are.
See doctrine/dbal#3697