Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 4.2 compatibility #883

Closed
komik966 opened this issue Dec 3, 2018 · 6 comments
Closed

Symfony 4.2 compatibility #883

komik966 opened this issue Dec 3, 2018 · 6 comments

Comments

@komik966
Copy link

komik966 commented Dec 3, 2018

Error:

TypeError: Argument 1 passed to Symfony\Bridge\Doctrine\PropertyInfo\DoctrineExtractor::__construct() must implement interface Doctrine\Common\Persistence\Mapping\ClassMetadataFactory, instance of Doctrine\ORM\EntityManager given

Possible cause:

DoctrineBundle/DependencyInjection/DoctrineExtension.php

Lines 801 to 803 in 82d2c63

if (interface_exists(PropertyInitializableExtractorInterface::class)) {
$argumentId = sprintf('doctrine.orm.%s_entity_manager', $entityManagerName);
} else {

@stof
Copy link
Member

stof commented Dec 3, 2018

/cc @dunglas

It looks like your change is broken.

@dunglas
Copy link
Contributor

dunglas commented Dec 3, 2018

Can you run composer info please? It looks like you use DoctrineBridge 4.1 with PropertyInfo 4.2.

@komik966
Copy link
Author

komik966 commented Dec 3, 2018

This was the problem. Thanks

@komik966 komik966 closed this as completed Dec 3, 2018
@dunglas dunglas mentioned this issue Dec 3, 2018
Closed
@dunglas
Copy link
Contributor

dunglas commented Dec 3, 2018

@komik966 can you try if #884 fixes your problem when using DoctrineBridge 4.1 with PropertyInfo 4.2 please?

@komik966
Copy link
Author

komik966 commented Dec 3, 2018

@dunglas Tested, works good, error disappeared

@dunglas
Copy link
Contributor

dunglas commented Dec 3, 2018

Thanks!

@xabbuh xabbuh mentioned this issue Jan 11, 2019
Closed
silverbackdan added a commit to silverbackdan/DoctrineBundle that referenced this issue Feb 3, 2019
@silverbackdan
Fix doctrine#883 with support for php 5
e6bf6d8
silverbackdan added a commit to silverbackdan/DoctrineBundle that referenced this issue Feb 3, 2019
@silverbackdan
Fix doctrine#883 with support for php 5
0970f65
silverbackdan added a commit to silverbackdan/DoctrineBundle that referenced this issue Feb 3, 2019
@silverbackdan
Fix doctrine#883 with support for php 5
ab01108
greg0ire added a commit to greg0ire/DoctrineBundle that referenced this issue Feb 4, 2019
@greg0ire
Detect doctrine bridge version
e4ed35f 
Although it is in the PropertyInfo sub namespace, the DoctrineExtractor
class is in the doctrine bridge, which means we should detect the
doctrine bridge version and not the PropertyInfo component version.

Fixes doctrine#883, Closes doctrine#884
@greg0ire greg0ire mentioned this issue Feb 4, 2019
Merged
greg0ire added a commit to greg0ire/DoctrineBundle that referenced this issue Feb 4, 2019
@greg0ire
Detect doctrine bridge version
165697f 
Although it is in the PropertyInfo sub namespace, the DoctrineExtractor
class is in the doctrine bridge, which means we should detect the
doctrine bridge version and not the PropertyInfo component version.

Fixes doctrine#883, Closes doctrine#884
greg0ire added a commit to greg0ire/DoctrineBundle that referenced this issue Feb 4, 2019
@greg0ire
Detect doctrine bridge version
7f4c376 
Although it is in the PropertyInfo sub namespace, the DoctrineExtractor
class is in the doctrine bridge, which means we should detect the
doctrine bridge version and not the PropertyInfo component version.

Fixes doctrine#883, Closes doctrine#884
greg0ire added a commit to greg0ire/DoctrineBundle that referenced this issue Feb 4, 2019
@greg0ire
Detect doctrine bridge version
98ab626 
Although it is in the PropertyInfo sub namespace, the DoctrineExtractor
class is in the doctrine bridge, which means we should detect the
doctrine bridge version and not the PropertyInfo component version.

Fixes doctrine#883, Closes doctrine#884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dunglas @stof @komik966