Detect doctrine bridge version #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
suggested changes
Feb 4, 2019
greg0ire
force-pushed
the
detect-proper-component
branch
from
e4ed35f
to
165697f
Compare
|
The only concern about this is the name of the property not being covered by the BC-promise. If this gets merged, I shall make a PR on |
greg0ire
force-pushed
the
detect-proper-component
branch
from
165697f
to
7f4c376
Compare
xabbuh
reviewed
Feb 4, 2019
Although it is in the PropertyInfo sub namespace, the DoctrineExtractor class is in the doctrine bridge, which means we should detect the doctrine bridge version and not the PropertyInfo component version. Fixes doctrine#883, Closes doctrine#884
greg0ire
force-pushed
the
detect-proper-component
branch
from
7f4c376
to
98ab626
Compare
xabbuh
approved these changes
Feb 5, 2019
|
Thanks for fixing @greg0ire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is in the PropertyInfo sub namespace, the DoctrineExtractor
class is in the doctrine bridge, which means we should detect the
doctrine bridge version and not the PropertyInfo component version.
Fixes #883, Closes #884