ci: migrate from Travis CI to GitHub Actions #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Travis CI is only _pseudo_-free after the .org -> .com merge - c.f. https://travis-ci.community/t/org-com-migration-unexpectedly-comes-with-a-plan-change-for-oss-what-exactly-is-the-new-deal/10567 - GH Actions are _actually_ free for OSS / public repos - and also offer a decent level of composability that's resulted in a huge surge in reusable community Actions (vs. CircleCI orbs etc haven't had nearly as much adoption) - and I've had a mostly great experience on them so far as well - add a matrix for OSes and different Go versions too - currently only using one Go version (as it was on Travis), but can add more later - currently only testing latest Ubuntu and macOS (as it was on Travis), but can add more versions and OSes later - note that tests fail on Windows right now (due to the shell?) - check for `$RUNNER_OS` instead of `$TRAVIS_OS_NAME` now - c.f. https://docs.github.com/en/actions/learn-github-actions/environment-variables - update the commented out "Debug" step to conditionally run on macOS as well
- tests failing on macOS b/c `sha256sum` doesn't exist - only use the third arg in the workaround as it doesn't support flags
agilgur5
force-pushed
the
ci-migrate-github-actions
branch
from
8381e8a
to
34ae1c6
Compare
|
Hmm, I'm guessing this has to be approved before CI runs on the PR? (per newer GitHub security features, and as this is the first workflow created and this is my first PR here, I think?) |
This was referenced Aug 13, 2022
|
Seems good, lets merge that. |
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate CI from Travis to GitHub Actions, ensure tests run on macOS
Details
Travis CI is only pseudo-free after the .org -> .com merge
GH Actions are actually free for OSS / public repos
add a matrix for OSes and different Go versions too
check for
$RUNNER_OSinstead of$TRAVIS_OS_NAMEnowfix: make
get_docoptswork on macOSsha256sumdoesn't existTesting
See CI success in my branch
Future Work
Will want to rename the
travisdirectory to something likeciinstead. I didn't do it in this PR as renames require a few changes and are easier to track in Git as a single commit -- I can do that in a separate PR after this is merged