Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda pagination limit #5889

Merged
merged 3 commits into from
May 22, 2024
Merged

lambda pagination limit #5889

merged 3 commits into from
May 22, 2024

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented May 17, 2024

Description
Add in a limit for how many lambda events to retrieve, match what we declared in openap.yaml already

Review Instructions
Could retrieve more than 100 events, should get 100

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5993

Security and Privacy

None

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.72%. Comparing base (0430bbe) to head (c0759b3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5889      +/-   ##
=============================================
- Coverage      73.73%   73.72%   -0.01%     
+ Complexity      5261     5260       -1     
=============================================
  Files            371      371              
  Lines          19206    19208       +2     
  Branches        2012     2012              
=============================================
+ Hits           14161    14162       +1     
  Misses          4091     4091              
- Partials         954      955       +1     
Flag Coverage Δ
bitbuckettests 27.12% <0.00%> (-0.01%) ⬇️
integrationtests 58.37% <100.00%> (+<0.01%) ⬆️
languageparsingtests 11.07% <0.00%> (-0.01%) ⬇️
localstacktests 21.68% <0.00%> (-0.01%) ⬇️
toolintegrationtests 30.48% <0.00%> (-0.01%) ⬇️
unit-tests_and_non-confidential-tests 28.45% <0.00%> (-0.01%) ⬇️
workflowintegrationtests 38.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen changed the title lambda limit lambda pagination limit May 21, 2024
Copy link

sonarcloud bot commented May 21, 2024

@denis-yuen denis-yuen marked this pull request as ready for review May 21, 2024 21:38
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096 and hyunnaye and removed request for a team, coverbeck, david4096 and hyunnaye May 21, 2024 21:38
@denis-yuen denis-yuen merged commit 75014d2 into develop May 22, 2024
18 checks passed
@denis-yuen denis-yuen deleted the feature/lambda_page_limit branch May 22, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants