Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cromwell version 84 to table for 1.14 #234

Merged
merged 1 commit into from Jan 25, 2023

Conversation

kathy-t
Copy link
Contributor

@kathy-t kathy-t commented Jan 23, 2023

https://ucsc-cgl.atlassian.net/browse/SEAB-4980

Adds a new row indicating that 1.14 uses cromwell version 84

@kathy-t kathy-t self-assigned this Jan 23, 2023
@denis-yuen
Copy link
Member

@aofarrel has worked/fought with the link check recently.
That said,

(             faq: line  174) redirect  https://help.github.com/en/articles/approving-oauth-apps-for-your-organization/ - permanently to https://docs.github.com/en/organizations/managing-oauth-access-to-your-organizations-data/approving-oauth-apps-for-your-organization
(             faq: line  169) redirect  https://help.github.com/en/articles/enabling-oauth-app-access-restrictions-for-your-organization/ - permanently to https://docs.github.com/en/organizations/managing-oauth-access-to-your-organizations-data/enabling-oauth-app-access-restrictions-for-your-organization
...
(advanced-topics/best-practices/best-practices-secure-fair-workflows: line   88) redirect  https://www.openshift.com/blog/mitigate-impact-of-docker-hub-pull-request-limits - with Found to https://cloud.redhat.com/blog/mitigate-impact-of-docker-hub-pull-request-limits

If these redirects are legit and/or causing the failure, it would be good to update them

@kathy-t
Copy link
Contributor Author

kathy-t commented Jan 25, 2023

(             faq: line  174) redirect  https://help.github.com/en/articles/approving-oauth-apps-for-your-organization/ - permanently to https://docs.github.com/en/organizations/managing-oauth-access-to-your-organizations-data/approving-oauth-apps-for-your-organization
(             faq: line  169) redirect  https://help.github.com/en/articles/enabling-oauth-app-access-restrictions-for-your-organization/ - permanently to https://docs.github.com/en/organizations/managing-oauth-access-to-your-organizations-data/enabling-oauth-app-access-restrictions-for-your-organization
...
(advanced-topics/best-practices/best-practices-secure-fair-workflows: line   88) redirect  https://www.openshift.com/blog/mitigate-impact-of-docker-hub-pull-request-limits - with Found to https://cloud.redhat.com/blog/mitigate-impact-of-docker-hub-pull-request-limits

If these redirects are legit and/or causing the failure, it would be good to update them

Hmm, I don't think they're causing the failure. The failure is this link, but the link works on my browser so I'm not sure what the problem is

(      dictionary: line  198) broken    https://biodatacatalyst.nhlbi.nih.gov/ - HTTPSConnectionPool(host='biodatacatalyst.nhlbi.nih.gov', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))

@denis-yuen
Copy link
Member

Oh, I think @aofarrel was looking into this, It looked like a known problem with the library that Sphinx uses for link checking. THink I'll override here since it's literally one line

@denis-yuen denis-yuen merged commit 5f05a17 into develop Jan 25, 2023
@denis-yuen denis-yuen deleted the feature/seab-4980/update-cromwell-version-doc branch January 25, 2023 15:12
@aofarrel
Copy link
Collaborator

aofarrel commented Feb 23, 2023

@denis-yuen @kathy-t FYI, here's some relevant information regarding link checking being a bit unreliable:

Previously, Sphinx's link checker had issues with self-signed certificates. Those issues seem to have been resolved.

@aofarrel
Copy link
Collaborator

See also https://www.ssllabs.com/ssltest/analyze.html?d=biodatacatalyst.nhlbi.nih.gov&s=13.35.125.17&latest (courtesy of Denis on Slack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants