Enhance builder inspection #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 78.18% 76.51% -1.67%
==========================================
Files 5 5
Lines 110 132 +22
Branches 19 20 +1
==========================================
+ Hits 86 101 +15
- Misses 18 23 +5
- Partials 6 8 +2
Continue to review full report at Codecov.
|
tonistiigi
reviewed
Apr 23, 2021
| if (line.startsWith('Platforms')) { | ||
| return line.replace('Platforms: ', '').replace(/\s/g, '').trim(); | ||
| const builder = {}; | ||
| itlines: for (const line of res.stdout.trim().split(`\n`)) { |
There was a problem hiding this comment.
follow up: should add json output (--format) for these in build later to avoid this text parsing. Has been asked in buildx repo before as well.
There was a problem hiding this comment.
Yes indeed would be better to support that directly on buildx.
There was a problem hiding this comment.
tonistiigi
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor builder inspection and add new outputs. In a follow-up PR we will be able to display buildkitd logs (
docker logs buildx_buildkit_${builder.node_name}) if docker-container is used to enhance debugging.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com