Add support for more platforms #17
Merged
+62
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 81.73% 77.19% -4.54%
==========================================
Files 5 5
Lines 104 114 +10
Branches 20 20
==========================================
+ Hits 85 88 +3
- Misses 13 19 +6
- Partials 6 7 +1
Continue to review full report at Codecov.
|
tonistiigi
approved these changes
Sep 8, 2020
| } | ||
| case 'arm': { | ||
| const arm_version = (process.config.variables as any).arm_version; | ||
| arch = arm_version ? 'arm-v' + arm_version : 'arm'; |
There was a problem hiding this comment.
I think we should change upstream to armv7 instead of arm-v7 so these hacks are not required(they are especially tricky in Dockerfiles). I'll try to remember to update this when we do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. crazy-max/ghaction-docker-buildx#223
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com