Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in README.md file around GAR authentication #693

Merged
merged 1 commit into from May 8, 2024

Conversation

dsotirakis
Copy link
Contributor

Looks like there may be some c/p issues. This PR addresses and fixes the issues.

Fixes a few issues in the login-action README.md file

Signed-off-by: Dimitris Sotirakis <sotirakis.dim@gmail.com>
@dsotirakis dsotirakis changed the title Fixes in README.md file around GAR authentication. Fixes in README.md file around GAR authentication Apr 4, 2024
@dsotirakis
Copy link
Contributor Author

@crazy-max 👋
Sorry for the direct mention - I see you review a lot of docs changes lately and I thought you could be the most appropriate person for this review! LMK if it makes sense!

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@crazy-max crazy-max merged commit 7840e6d into docker:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants