ci(codeql): restrict code scanning to src folder #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
twelsh-aw
approved these changes
Oct 24, 2023
| @@ -37,6 +37,9 @@ jobs: | |||
| uses: github/codeql-action/init@v2 | |||
| with: | |||
| languages: ${{ matrix.language }} | |||
| config: | | |||
| paths: | |||
| - src | |||
There was a problem hiding this comment.
probably makes sense to remove lines :10 and :15 as well, to not trigger this action redundantly
There was a problem hiding this comment.
I think we still need these so CodeQL is triggered when dist has changed, which means a dependency in package.json has been updated and therefore might change the behavior of the project.
There was a problem hiding this comment.
:ack ok that makes sense to me. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL currently scans
distfolder which contains source code not introduced by this repository and could trigger false-positives. This should only scansrcfolder per https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#specifying-directories-to-scan