Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for use of loginStandard functionality with docker login #50

Closed
wants to merge 6 commits into from
Closed

allow for use of loginStandard functionality with docker login #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2619919
Update action.yml
dbeal-wiser Dec 30, 2020
1e9c9b4
Update docker.ts
dbeal-wiser Dec 30, 2020
28ede9d
Update docker.ts
dbeal-wiser Dec 30, 2020
3467725
Update main.ts
dbeal-wiser Dec 30, 2020
d61c413
update dist
dbeal-wiser Dec 30, 2020
ffc923a
update readme
dbeal-wiser Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -379,6 +379,7 @@ Following inputs can be used as `step.with` keys
| Name | Type | Default | Description |
|------------------|---------|-----------------------------|------------------------------------|
| `registry` | String | | Server address of Docker registry. If not set then will default to Docker Hub |
| `isECR` | String | Detected automatically | Specifies whether the given registry is ECR, either `true` or `false` |
| `username` | String | | Username used to log against the Docker registry |
| `password` | String | | Password or personal access token used to log against the Docker registry |
| `logout` | Bool | `true` | Log out from the Docker registry at the end of a job |
Expand Down
3 changes: 3 additions & 0 deletions action.yml
View file
Open in desktop
Expand Up @@ -10,6 +10,9 @@ inputs:
registry:
description: 'Server address of Docker registry. If not set then will default to Docker Hub'
required: false
isECR:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think naming it ecr is enough

description: 'Specifies whether the given registry is ECR, either `true` or `false`. Uses regex by default to detect automatically'
required: false
username:
description: 'Username used to log against the Docker registry'
required: false
Expand Down