Merge pull request #160 from crazy-max/node12

Revert to Node 12 as default runtime
docker · Mar 1, 2022 · dd4fa06 · dd4fa06
2 parents bb984ef + 4e35385
commit dd4fa06
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 29 deletions.
diff --git a/action.yml b/action.yml
@@ -26,6 +26,6 @@ inputs:
     required: false
 
 runs:
-  using: 'node16'
+  using: 'node12'
   main: 'dist/index.js'
   post: 'dist/index.js'
diff --git a/hack/build.Dockerfile → dev.Dockerfile b/hack/build.Dockerfile → dev.Dockerfile
@@ -1,6 +1,6 @@
 # syntax=docker/dockerfile:1.3-labs
 
-ARG NODE_VERSION
+ARG NODE_VERSION=12
 ARG DOCKER_VERSION=20.10.10
 ARG BUILDX_VERSION=0.7.0
 

diff --git a/docker-bake.hcl b/docker-bake.hcl
@@ -1,13 +1,3 @@
-variable "NODE_VERSION" {
-  default = "16"
-}
-
-target "node-version" {
-  args = {
-    NODE_VERSION = NODE_VERSION
-  }
-}
-
 group "default" {
   targets = ["build"]
 }
@@ -21,50 +11,43 @@ group "validate" {
 }
 
 target "build" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "build-update"
   output = ["."]
 }
 
 target "build-validate" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "build-validate"
   output = ["type=cacheonly"]
 }
 
 target "format" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "format-update"
   output = ["."]
 }
 
 target "format-validate" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "format-validate"
   output = ["type=cacheonly"]
 }
 
 target "vendor-update" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "vendor-update"
   output = ["."]
 }
 
 target "vendor-validate" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "vendor-validate"
   output = ["type=cacheonly"]
 }
 
 target "test" {
-  inherits = ["node-version"]
-  dockerfile = "./hack/build.Dockerfile"
+  dockerfile = "dev.Dockerfile"
   target = "test-coverage"
   output = ["./coverage"]
 }
diff --git a/package.json b/package.json
@@ -13,9 +13,6 @@
     "type": "git",
     "url": "git+https://github.com/docker/login-action.git"
   },
-  "engines": {
-    "node": "^16"
-  },
   "keywords": [
     "actions",
     "docker",