This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] Add TC to check dynamic subnet for ingress network #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com> (cherry picked from commit 084f5ab) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
kolyshkin
approved these changes
Oct 23, 2019
|
[2019-10-23T17:08:36.806Z] integration/network/service_test.go:369:32:warning: undeclared name: ctx (gosimple) |
kolyshkin
reviewed
Oct 23, 2019
| assert.Equal(t, out.IPAM.Config[0].Subnet, "20.20.1.0/24") | ||
|
|
||
| // Also inspect ingress network and make sure its in the same subnet | ||
| out, err = cli.NetworkInspect(ctx, "ingress", types.NetworkInspectOptions{Verbose: true}) |
There was a problem hiding this comment.
[2019-10-23T17:08:36.806Z] integration/network/service_test.go:369:32:warning: undeclared name: ctx (gosimple)
There was a problem hiding this comment.
I guess s/ctx/context.Background()/ or backport moby#38557
There was a problem hiding this comment.
hm.. no, looks like we need moby#39671
.... which is in the other PR 😂
There was a problem hiding this comment.
No, that one is already backported
There was a problem hiding this comment.
hm.. perhaps it was not 🤔
There was a problem hiding this comment.
arf; likely also moby#39332, which is also in the other PR
|
this was included in #401 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of the test from moby#39966, because the related swarmkit changes were included in #346