-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: refresh containerd examples #17106
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@thaJeztah @rumpl ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on removing some of that content (agreed that it's not very useful).
Left some comments / thoughts on what to show on some of the output
d787709
to
cec4f0c
Compare
Signed-off-by: David Karlsson <david.karlsson@docker.com>
cec4f0c
to
7a1773a
Compare
Signed-off-by: David Karlsson <david.karlsson@docker.com>
c72d36a
to
43de7a9
Compare
|
||
Docker Engine already uses containerd for container lifecycle management, which | ||
includes creating, starting, and stopping containers. This page describes the | ||
next step of containerd integration for Docker Engine: the image store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove the whole "image store" wording and say : image management
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ docker ps | ||
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES | ||
93b4d60dfd08 nginx "/docker-entrypoint.…" 3 seconds ago Up 3 seconds 0.0.0.0:8080->80/tcp stoic_mccarthy | ||
$ docker buildx create --bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering now if we need to show the docker buildx create
step at all; would the error-message that's shown above be enough to illustrate what doesn't work without the integration enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to keep it, for those who might be familiar with multi-platform builds using the docker-container
driver, to illustrate the limitation with --load
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha. Yeah, was wondering if users would potentially run the example (and it's only there to illustrate "this is no longer needed")
We good with this @rumpl @thaJeztah ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have a feeling we have more to say in the limitations section. |
Signed-off-by: David Karlsson david.karlsson@docker.com
Proposed changes
This refreshes the containerd examples.
This removes some
docker info
anddocker run
examples, which IMO don't add a lot of useful information.I also rewrote the section no multi-platform builds in an attempt to improve it.
Related issues (optional)
This update was actually triggered by the fact that we should remove the
Registry:
field fromdocker info
.See: docker/cli#4204