Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile ref: use custom ref to fix links issue #15972

Merged
merged 1 commit into from Oct 25, 2022

Conversation

crazy-max
Copy link
Member

Changes merged in moby/buildkit#3220 cause htmlproofer errors: https://github.com/docker/docs/actions/runs/3319903637/jobs/5485635979#step:5:57

image

- ./_site/engine/reference/builder/index.html
  *  internally linking to /build/buildkit/, which does not exist (line 269)
     <a href="/build/buildkit/">BuildKit</a>
  *  internally linking to /build/buildkit/, which does not exist (line 2478)
     <a href="/build/buildkit/">BuildKit</a>
  *  internally linking to /build/buildkit/dockerfile-frontend/, which does not exist (line 272)
     <a href="/build/buildkit/dockerfile-frontend/">Custom Dockerfile syntax</a>
  *  linking to internal hash #getting-started that does not exist (line 3000)
     <a href="/build/buildkit/#getting-started">BuildKit</a>
- ./_site/engine/reference/commandline/build/index.html
  *  linking to internal hash #buildkit that does not exist (line 849)
     <a href="/engine/reference/builder/#buildkit">BuildKit backend</a>
  *  linking to internal hash #buildkit that does not exist (line 1114)
     <a href="/engine/reference/builder/#buildkit">enable BuildKit</a>
  *  linking to internal hash #buildkit that does not exist (line 1156)
     <a href="/engine/reference/builder/#buildkit">enable BuildKit</a>

While waiting for #15958 and docker/cli#3832 to be merged, use a custom ref for the Dockerfile reference before these changes.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 84e03b9
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6357bce1c01a6c0008a11859
😎 Deploy Preview https://deploy-preview-15972--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dvdksn dvdksn merged commit 21b49e9 into docker:main Oct 25, 2022
@crazy-max crazy-max deleted the temp-buildkit-ref branch October 25, 2022 11:14
@crazy-max crazy-max added the area/build Relates to Dockerfiles or docker build command label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants