compose: merge latest spec changes #15539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tmpfs.mode: compose-spec/compose-spec#252 * build.tags: compose-spec/compose-spec#255 * env var secrets: compose-spec/compose-spec#257 * build.platforms: compose-spec/compose-spec#267 Signed-off-by: Milas Bowman <milas.bowman@docker.com>
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@dockertopia I diffed the upstream files spec.md and build.md and pulled all the changes over here. |
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
dockertopia
reviewed
Sep 1, 2022
From Dora in code review Co-authored-by: Dockertopia <103652162+dockertopia@users.noreply.github.com>
|
I committed most of the suggestions and left comments on the others. Reminder: We'll need to (manually) merge these changes back upstream into |
Minor edits for clarification
dockertopia
approved these changes
Sep 1, 2022
Oops I had missed this notification. But I think everything is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Manually merged latest changes from compose-spec/compose-spec:
tmpfs.modecompose-spec/compose-spec#252Related issues (optional)
JIRA: EN-194