Add Tmpfs support to the python API #939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone explain why the unittests are failling? |
|
The expected output doesn't match the actual output. Look at |
|
Ah. A typo. Should be fixed now. |
|
Wtf, They ARE signed ... |
This adds support for the Tmpfs option introduced in Docker 1.10. See: moby/moby#13587 Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
| if not isinstance(tmpfs, list): | ||
| raise ValueError( | ||
| 'Tmpfs spec must be a list' | ||
| ) |
There was a problem hiding this comment.
There seems to be some inconsistencies in the error messages here. This one says must be a list, but the previous branch accepted dicts. The next one says they must be something else.
Merged
|
Merged as part of #994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the recently (1.10) added "--tmpfs" option in docker.
It is used to made private temporary filesystem mounts inside the container,
even if the container itself is not privileged to mount anything. Its a bit modeled
after the "binds" feature for volumes. The first commit provide the necessary
code changes. The second provides some unittests and the third adds
documentation.
You can see details about the tmpfs feature in the related docker PR:
moby/moby#13587