Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prune test to use anonymous volumes #3051

Merged
merged 1 commit into from Oct 5, 2022
Merged

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Oct 3, 2022

This is related to moby/moby#44216
Prunes will, by default, no longer prune named volumes, only anonymous ones.

thaJeztah
thaJeztah previously approved these changes Oct 3, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@milas PTAL 🤗

@thaJeztah
Copy link
Member

Hmmm doesn't seem to work though;

TestVolumes.test_prune_volumes ________________________
tests/integration/api_volume_test.py:61: in test_prune_volumes
    self.tmp_volumes.append(v.name)
E   AttributeError: 'dict' object has no attribute 'name'

@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Oct 3, 2022

Yep, having trouble getting tests to run locally.

This is related to moby/moby#44216
Prunes will, by default, no longer prune named volumes, only anonymous ones.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Oct 3, 2022

Ok, I think this is good now.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

LGTM

@milas milas merged commit bc0a5fb into docker:main Oct 5, 2022
@milas milas added this to the 6.x-next milestone Oct 5, 2022
@cpuguy83 cpuguy83 deleted the patch-1 branch October 5, 2022 18:20
DeliciousHouse added a commit to DeliciousHouse/docker-py that referenced this pull request Oct 20, 2022
This is related to moby/moby#44216

Prunes will, by default, no longer prune named volumes, only anonymous ones.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
coolguy1771 pushed a commit to coolguy1771/home-ops that referenced this pull request Nov 3, 2022
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker](https://togithub.com/docker/docker-py)
([changelog](https://docker-py.readthedocs.io/en/stable/change-log.html))
| patch | `6.0.0` -> `6.0.1` |

---

### Release Notes

<details>
<summary>docker/docker-py</summary>

### [`v6.0.1`](https://togithub.com/docker/docker-py/releases/tag/6.0.1)

[Compare
Source](https://togithub.com/docker/docker-py/compare/6.0.0...6.0.1)

##### 🐛 Bugfixes

- Fix for `The pipe has been ended` errors on Windows
([#&#8203;3056](https://togithub.com/docker/docker-py/issues/3056))
- Support floats for timestamps in Docker logs (`since` / `until`)
([#&#8203;3031](https://togithub.com/docker/docker-py/issues/3031))

##### What's Changed

- docs: install package in ReadTheDocs build by
[@&#8203;milas](https://togithub.com/milas) in
[docker/docker-py#3032
- Use latest stable syntax for Dockerfiles by
[@&#8203;thaJeztah](https://togithub.com/thaJeztah) in
[docker/docker-py#3035
- feat: add support for floats to docker logs params since / until sinc…
by [@&#8203;ArchiMoebius](https://togithub.com/ArchiMoebius) in
[docker/docker-py#3031
- Change prune test to use anonymous volumes by
[@&#8203;cpuguy83](https://togithub.com/cpuguy83) in
[docker/docker-py#3051
- socket: handle npipe close by
[@&#8203;nicks](https://togithub.com/nicks) in
[docker/docker-py#3056

##### New Contributors

- [@&#8203;ArchiMoebius](https://togithub.com/ArchiMoebius) made their
first contribution in
[docker/docker-py#3031
- [@&#8203;nicks](https://togithub.com/nicks) made their first
contribution in
[docker/docker-py#3056

**Full Changelog**:
docker/docker-py@6.0.0...6.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMi4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTIuMSJ9-->

Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants