Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for floats to docker logs params since / until sinc… #3031

Merged
merged 6 commits into from Aug 19, 2022

Conversation

ArchiMoebius
Copy link
Contributor

feature to add support for floats to docker container logs method params since / until due to the fact that docker engine supports it

Related:
#1515
#2825

…e the docker engine supports it

Signed-off-by: Archi Moebius <poerhiz@gmail.com>
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Looks good -- just a couple tiny suggestions to update the error messages for unsupported types.

docker/api/container.py Outdated Show resolved Hide resolved
docker/api/container.py Outdated Show resolved Hide resolved
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah another thing - "in nanoseconds" is misleading

docker/api/container.py Outdated Show resolved Hide resolved
docker/api/container.py Outdated Show resolved Hide resolved
@milas milas modified the milestones: 6.0.0, 6.1.0 Aug 18, 2022
ArchiMoebius and others added 5 commits August 18, 2022 20:30
Co-authored-by: Milas Bowman <milasb@gmail.com>
Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Co-authored-by: Milas Bowman <milasb@gmail.com>
Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Co-authored-by: Milas Bowman <milasb@gmail.com>
Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Co-authored-by: Milas Bowman <milasb@gmail.com>
Signed-off-by: Rhiza <6900588+ArchiMoebius@users.noreply.github.com>
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@milas milas merged commit 923e067 into docker:main Aug 19, 2022
@ArchiMoebius ArchiMoebius deleted the feature_floating_docker_logs branch August 20, 2022 01:33
coolguy1771 pushed a commit to coolguy1771/home-ops that referenced this pull request Nov 3, 2022
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker](https://togithub.com/docker/docker-py)
([changelog](https://docker-py.readthedocs.io/en/stable/change-log.html))
| patch | `6.0.0` -> `6.0.1` |

---

### Release Notes

<details>
<summary>docker/docker-py</summary>

### [`v6.0.1`](https://togithub.com/docker/docker-py/releases/tag/6.0.1)

[Compare
Source](https://togithub.com/docker/docker-py/compare/6.0.0...6.0.1)

##### 🐛 Bugfixes

- Fix for `The pipe has been ended` errors on Windows
([#&#8203;3056](https://togithub.com/docker/docker-py/issues/3056))
- Support floats for timestamps in Docker logs (`since` / `until`)
([#&#8203;3031](https://togithub.com/docker/docker-py/issues/3031))

##### What's Changed

- docs: install package in ReadTheDocs build by
[@&#8203;milas](https://togithub.com/milas) in
[docker/docker-py#3032
- Use latest stable syntax for Dockerfiles by
[@&#8203;thaJeztah](https://togithub.com/thaJeztah) in
[docker/docker-py#3035
- feat: add support for floats to docker logs params since / until sinc…
by [@&#8203;ArchiMoebius](https://togithub.com/ArchiMoebius) in
[docker/docker-py#3031
- Change prune test to use anonymous volumes by
[@&#8203;cpuguy83](https://togithub.com/cpuguy83) in
[docker/docker-py#3051
- socket: handle npipe close by
[@&#8203;nicks](https://togithub.com/nicks) in
[docker/docker-py#3056

##### New Contributors

- [@&#8203;ArchiMoebius](https://togithub.com/ArchiMoebius) made their
first contribution in
[docker/docker-py#3031
- [@&#8203;nicks](https://togithub.com/nicks) made their first
contribution in
[docker/docker-py#3056

**Full Changelog**:
docker/docker-py@6.0.0...6.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMi4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTIuMSJ9-->

Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants