Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshcon: remove use of self.ssh_conf #2993

Merged
merged 2 commits into from Jul 26, 2022
Merged

Conversation

glicht
Copy link
Contributor

@glicht glicht commented May 31, 2022

Use of self.ssh_conf was left over after being removed at the following PR: #2846

This PR removes the use of it and uses host_config instead.

Encountered this when trying to use an ssh based DOCKER_HOST which uses a ProxyCommand config. Was getting the following error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/glicht/.pyenv/versions/3.10.1/lib/python3.10/site-packages/docker/client.py", line 45, in __init__
    self.api = APIClient(*args, **kwargs)
  File "/Users/glicht/.pyenv/versions/3.10.1/lib/python3.10/site-packages/docker/api/client.py", line 171, in __init__
    self._custom_adapter = SSHHTTPAdapter(
  File "/Users/glicht/.pyenv/versions/3.10.1/lib/python3.10/site-packages/docker/transport/sshconn.py", line 176, in __init__
    self._create_paramiko_client(base_url)
  File "/Users/glicht/.pyenv/versions/3.10.1/lib/python3.10/site-packages/docker/transport/sshconn.py", line 207, in _create_paramiko_client
    self.ssh_conf['proxycommand']
AttributeError: 'SSHHTTPAdapter' object has no attribute 'ssh_conf'

Signed-off-by: Guy Lichtman <glicht@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants