Fixed value for missing host port for newer docker desktop versions

Signed-off-by: Ben Avrahami <avrahami.ben@gmail.com>
docker · Jul 26, 2021 · 9f3f97c · 9f3f97c
1 parent a9748a8
commit 9f3f97c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docker/utils/utils.py b/docker/utils/utils.py
@@ -88,7 +88,7 @@ def _convert_port_binding(binding):
         result['HostPort'] = binding
 
     if result['HostPort'] is None:
-        result['HostPort'] = ''
+        result['HostPort'] = '0'
     else:
         result['HostPort'] = str(result['HostPort'])
 

diff --git a/tests/unit/api_container_test.py b/tests/unit/api_container_test.py
@@ -577,7 +577,7 @@ def test_create_container_with_port_binds(self):
         assert '4444/tcp' in port_bindings
         assert '5555/tcp' in port_bindings
         assert '6666/tcp' in port_bindings
-        assert [{"HostPort": "", "HostIp": ""}] == port_bindings['1111/tcp']
+        assert [{"HostPort": "0", "HostIp": ""}] == port_bindings['1111/tcp']
         assert [
             {"HostPort": "2222", "HostIp": ""}
         ] == port_bindings['2222/tcp']

diff --git a/tests/unit/models_containers_test.py b/tests/unit/models_containers_test.py
@@ -163,7 +163,7 @@ def test_create_container_args(self):
                 'PidsLimit': 500,
                 'PortBindings': {
                     '1111/tcp': [{'HostIp': '', 'HostPort': '4567'}],
-                    '2222/tcp': [{'HostIp': '', 'HostPort': ''}]
+                    '2222/tcp': [{'HostIp': '', 'HostPort': '0'}]
                 },
                 'Privileged': True,
                 'PublishAllPorts': True,