simplify "go build" commands #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to specify the file to build, as we're building the "main" packages as a whole. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 51.13% 51.13%
=======================================
Files 9 9
Lines 659 659
=======================================
Hits 337 337
Misses 286 286
Partials 36 36 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
crazy-max
approved these changes
Aug 21, 2022
|
Cloning this repository on Linux and running make pass
mkdir -p bin
go build -o bin/docker-credential-pass pass/cmd/
cannot find package "." in:
/home/ubuntu/docker-credential-helpers/vendor/pass/cmd
make: *** [Makefile:26: pass] Error 1Running I'm on Ubuntu 22.04 with |
|
Oh! I think I see what may be wrong; does it work if you change the makefile to use; |
Yes, thank you. That fixes the issue. |
ZauberNerd
added a commit
to ZauberNerd/docker-credential-helpers
that referenced
this pull request
Aug 25, 2022
ZauberNerd
added a commit
to ZauberNerd/docker-credential-helpers
that referenced
this pull request
Aug 25, 2022
docker#232 (comment) Fixes docker#232 Signed-off-by: Björn Brauer <bjoern.brauer@new-work.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to specify the file to build, as we're building the "main" packages as a whole.