Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint gha job and remove travis #231

Merged
merged 3 commits into from Aug 21, 2022
Merged

lint gha job and remove travis #231

merged 3 commits into from Aug 21, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 20, 2022

use golangci-lint and adds ci validation

this was the last piece in travis so we can remove travis config. I also found the pass tests were not covered because gpg key and pass was not initialized. Now pass tests run both on ci and in the Dockerfile.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #231 (f522992) into master (5302241) will increase coverage by 4.11%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   51.13%   55.25%   +4.11%     
==========================================
  Files           9        9              
  Lines         659      666       +7     
==========================================
+ Hits          337      368      +31     
+ Misses        286      255      -31     
- Partials       36       43       +7     
Impacted Files Coverage Δ
pass/pass.go 65.48% <66.66%> (+24.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crazy-max crazy-max marked this pull request as draft August 20, 2022 22:57
@crazy-max crazy-max marked this pull request as ready for review August 21, 2022 00:40
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments, but otherwise looks good, thanks!

.github/workflows/build.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
ci/before_script_linux.sh Show resolved Hide resolved
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 5a61a5b into docker:master Aug 21, 2022
@crazy-max crazy-max deleted the lint branch August 21, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants